Skip to content

[Chore] Remove Nemotron-Nano-VL config copy#28126

Merged
DarkLight1337 merged 2 commits intovllm-project:mainfrom
Isotr0py:clean-nemotron-config
Nov 5, 2025
Merged

[Chore] Remove Nemotron-Nano-VL config copy#28126
DarkLight1337 merged 2 commits intovllm-project:mainfrom
Isotr0py:clean-nemotron-config

Conversation

@Isotr0py
Copy link
Member

@Isotr0py Isotr0py commented Nov 5, 2025 •
edited by github-actions bot
Loading

Purpose

  • Remove Nemotron_Nano_VL_Config copy, because the config backward compatibility issue has been resolved in recent Transformers release.

Test Plan

python examples/offline_inference/vision_language.py -m nemotron_vl

Test Result

Model can still generate reasonable outputs after cleanup.

Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

@Isotr0py
clean nemotron config
91a52f6 
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
@Isotr0py Isotr0py marked this pull request as ready for review November 5, 2025 14:15
DarkLight1337
DarkLight1337 reviewed Nov 5, 2025
View reviewed changes
@Isotr0py
reorder
e36679b 
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) November 5, 2025 15:18
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 5, 2025
@DarkLight1337 DarkLight1337 merged commit ffb0837 into vllm-project:main Nov 5, 2025
46 checks passed
@Isotr0py Isotr0py deleted the clean-nemotron-config branch November 6, 2025 03:09
ZhengHongming888 pushed a commit to ZhengHongming888/vllm that referenced this pull request Nov 8, 2025
@Isotr0py @ZhengHongming888
[Chore] Remove Nemotron-Nano-VL config copy (vllm-project#28126)
75c89cb 
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
devpatelio pushed a commit to SumanthRH/vllm that referenced this pull request Nov 29, 2025
@Isotr0py @devpatelio
[Chore] Remove Nemotron-Nano-VL config copy (vllm-project#28126)
8ad2950 
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
@ppham-nv
Copy link

ppham-nv commented Dec 3, 2025 •
edited
Loading

@russellb GHSA-8fr4-5q9j-m8gm do you think you can update the minimum affected version to say >= 0.10.0 ? vLLM didn't add this config in until this commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Isotr0py @ppham-nv @DarkLight1337